Skip to content

[codex] Remove missed alarm catch-up scheduling#521

Merged
jjoonleo merged 2 commits into
mainfrom
feature/remove-ios-alarm-catch-up
Jun 26, 2026
Merged

[codex] Remove missed alarm catch-up scheduling#521
jjoonleo merged 2 commits into
mainfrom
feature/remove-ios-alarm-catch-up

Conversation

@jjoonleo

Copy link
Copy Markdown
Contributor

Summary

  • Remove the remaining missed-alarm catch-up path from alarm reconciliation.
  • Keep reconciliation limited to alarms whose computed alarm time is still in the future.
  • Update regression tests so just-missed alarms are skipped and already armed just-missed alarms are cleaned up instead of rearmed.

Root cause

A previous commit removed the near-term schedule catch-up path, but the older recently-missed alarm catch-up path still adjusted past alarm times to now + 5 seconds. On iOS, app resume reconciliation could therefore schedule another native alarm shortly after the original 5-minute-before alarm had already fired.

Validation

  • rg -n "recentlyMissed|missedAlarmCatchUp|DeliveryDelay|GracePeriod|adjustedAlarmTime|isRecentlyMissed|isUpcomingScheduleCatchUp" lib test || true returned no matches.
  • flutter test test/domain/use-cases/reconcile_alarms_use_case_test.dart
  • flutter analyze

@jjoonleo jjoonleo marked this pull request as ready for review June 26, 2026 11:58
@jjoonleo jjoonleo merged commit 8ae2e8e into main Jun 26, 2026
3 of 6 checks passed
@jjoonleo jjoonleo deleted the feature/remove-ios-alarm-catch-up branch June 26, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant