Skip to content

[codex] Smooth social sign-in transitions#523

Merged
jjoonleo merged 2 commits into
mainfrom
feature/social-login-loading-gates
Jun 27, 2026
Merged

[codex] Smooth social sign-in transitions#523
jjoonleo merged 2 commits into
mainfrom
feature/social-login-loading-gates

Conversation

@jjoonleo

Copy link
Copy Markdown
Contributor

Summary

  • Keep Apple and Google sign-in buttons visible while the OnTime session is still being established, and disable repeat taps during that pending state.
  • Move social sign-in orchestration into SignInMainScreen so Apple and Google share pending, cancellation, and failure behavior.
  • Show the existing destructive/error-styled modal for social sign-in failures instead of a snackbar.
  • Redirect authenticated first-install users directly to the notification allow route when notification permission is required, even if the alarm gate is still resolving.

Why

Provider authentication can complete before the OnTime backend session is established. That left a gap where the native/provider prompt disappeared but the app had not routed into the signed-in experience yet. On first install, the router could also detour through splash because unresolved alarm state was checked before the required notification gate.

Validation

  • dart format on changed Dart files
  • flutter test --reporter compact
  • flutter analyze
  • git diff --check

jjoonleo added 2 commits June 27, 2026 23:34
…loading-gates

# Conflicts:
#	lib/presentation/shared/router/go_router.dart
@jjoonleo jjoonleo marked this pull request as ready for review June 27, 2026 14:46
@jjoonleo jjoonleo merged commit 616fb54 into main Jun 27, 2026
3 of 5 checks passed
@jjoonleo jjoonleo deleted the feature/social-login-loading-gates branch June 27, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant