Add lamella tomography experiment type id - #848
Merged
Conversation
tieneupin
reviewed
Jul 30, 2026
tieneupin
approved these changes
Jul 30, 2026
tieneupin
left a comment
tieneupin
left a comment
Contributor
There was a problem hiding this comment.
Optional suggestion for trimming down the number of lines, but other than that, looks good. Any chance of adding tests for the lamella tomography workflow as part of this PR?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
==========================================
+ Coverage 54.55% 54.57% +0.01%
==========================================
Files 104 104
Lines 11078 11081 +3
Branches 1470 1471 +1
==========================================
+ Hits 6044 6047 +3
Misses 4714 4714
Partials 320 320 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ispyb now has a different experiment type id for lamella tomography compared to grid tomo