Correct smartem foil hole position registration - #852
Merged
Conversation
…tem insert needs to happen first as we want the foil hole positions on the full res image for that preferrably we would untangle this a bit in the future so there is no implicit mutation of the data
stephen-riggs
approved these changes
Aug 4, 2026
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
- Coverage 54.57% 54.36% -0.21%
==========================================
Files 104 104
Lines 11081 11204 +123
Branches 1471 1508 +37
==========================================
+ Hits 6047 6091 +44
- Misses 4714 4790 +76
- Partials 320 323 +3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smartem needs the unscaled foil hole positions on the grid square image because it doesn't use a thumbnailed image. This wasn't happening as a side-effect of a mutation of the foil hole data in the function that inserts foil holes in ISPyB.