Skip to content

Do not in-place mutate in the ispyb functions - #853

Merged
stephen-riggs merged 1 commit into
mainfrom
ispyb-no-mutate
Aug 4, 2026
Merged

Do not in-place mutate in the ispyb functions#853
stephen-riggs merged 1 commit into
mainfrom
ispyb-no-mutate

Conversation

@stephen-riggs

Copy link
Copy Markdown
Contributor

This in-place mutation is unintentional and may impact the values we insert into the databases, particularly with the calculations about search map locations

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.54%. Comparing base (a73c037) to head (b76c064).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   54.52%   54.54%   +0.01%     
==========================================
  Files         104      104              
  Lines       11092    11092              
  Branches     1472     1472              
==========================================
+ Hits         6048     6050       +2     
+ Misses       4723     4721       -2     
  Partials      321      321              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephen-riggs
stephen-riggs merged commit 06e4cb9 into main Aug 4, 2026
14 checks passed
@stephen-riggs
stephen-riggs deleted the ispyb-no-mutate branch August 4, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants