PikaTransport: use numeric subscription IDs internally#85
Merged
Conversation
and make existing ones more precise
and only convert to strings at the pika API boundary. Write the numeric subscription ID into message headers when passing them to the subscribed callback functions, so they can be used to ACK/NACK later.
Codecov Report
@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 77.00% 77.23% +0.22%
==========================================
Files 22 22
Lines 1922 1915 -7
Branches 325 323 -2
==========================================
- Hits 1480 1479 -1
+ Misses 375 369 -6
Partials 67 67 |
ndevenish
reviewed
Oct 13, 2021
ndevenish
approved these changes
Oct 13, 2021
slightly modify the SampleConsumer to make it easier to use as a base for these kind of tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And pass the subscription ID to the callback functions as part of the message headers, so that
ack()/nack()calls work as expected.