Skip to content

Added typography fonts and styles into theme through tokens - #222

Merged
zoharma merged 2 commits into
mainfrom
zma/ds-theme-typography
Aug 5, 2026
Merged

Added typography fonts and styles into theme through tokens#222
zoharma merged 2 commits into
mainfrom
zma/ds-theme-typography

Conversation

@zoharma

@zoharma zoharma commented Jun 17, 2026

Copy link
Copy Markdown
Contributor
  • Moved Inter to its own file and adde more typefaces
  • Introduced tokens for typography styles
  • Updated theme accordingly

zoharma added a commit that referenced this pull request Jun 17, 2026
@zoharma zoharma changed the title Added typography fonts and styles and into theme through tokens Added typography fonts and styles into theme through tokens Jun 23, 2026
@zoharma
zoharma force-pushed the zma/ds-theme-typography branch 4 times, most recently from 0696ba4 to 7d16dd3 Compare June 24, 2026 08:41
@zoharma
zoharma marked this pull request as draft June 24, 2026 09:22
@zoharma
zoharma force-pushed the zma/ds-theme-typography branch 2 times, most recently from 1137a55 to ca06256 Compare June 24, 2026 10:36
@zoharma

zoharma commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

This is ready apart from the way to pull in the fonts as dependencies or direcly @VictoriaBeilsten-Edmands @akademy

zoharma added a commit that referenced this pull request Jul 6, 2026
zoharma added a commit that referenced this pull request Jul 10, 2026
@zoharma zoharma added the v0.6.3 label Jul 17, 2026
@zoharma
zoharma force-pushed the zma/ds-theme-typography branch 2 times, most recently from f9ee030 to dc6e8d0 Compare July 30, 2026 10:20
Update pnpm lock and package
Dependency and call update
- Adding calls directly in theme
- Switched storybook stylesheet calls
- Fixed typography calls and updated imports
- updated tests
@zoharma
zoharma force-pushed the zma/ds-theme-typography branch from dc6e8d0 to b9d252f Compare July 30, 2026 10:28
@zoharma
zoharma marked this pull request as ready for review July 30, 2026 10:30
zoharma added a commit that referenced this pull request Jul 30, 2026
zoharma added a commit that referenced this pull request Jul 30, 2026
Added icons pack to show icons
Typography is based on the typography #222
Icons is standalone
zoharma added a commit that referenced this pull request Jul 30, 2026
1. colours
2. typography
3. Icons

Updated typography to align with #222

Adding foundations section

1. colours
2. typography
3. Icons

Adding theme colours page

- Adding theme colours page with breakdown of colour tokens for light and dark
- Added a light/dark section to colours page
- Adding the relevant css and ability to do so.
- Remove typography and icons (to be pushed to another PR)

Added typography and icons

Added icons pack to show icons
Typography is based on the typography #222
Icons is standalone
zoharma added a commit that referenced this pull request Jul 30, 2026
Added:
2. typography
3. Icons
+
- Added icons pack to show icons
- Updated typography to align with #222
- Icons is standalone
Comment thread .storybook/preview.tsx Outdated
Comment thread src/themes/DiamondDSTheme.ts Outdated
Comment thread src/themes/createDiamondTypography.ts
Comment thread src/themes/DiamondDSTheme.ts
Comment thread src/themes/DiamondDSTheme.test.ts
- Added tests
- Added missing variants
- Removed fonts and css from preview.tsx
@zoharma
zoharma merged commit 2311a1d into main Aug 5, 2026
2 checks passed
@zoharma
zoharma deleted the zma/ds-theme-typography branch August 5, 2026 14:11
zoharma added a commit that referenced this pull request Aug 6, 2026
Added:
2. typography
3. Icons
+
- Added icons pack to show icons
- Updated typography to align with #222
- Icons is standalone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants