Add afterNavSlot and footerSlot to SidebarNav - #270
Open
zoharma wants to merge 1 commit into
Open
Conversation
zoharma
marked this pull request as ready for review
August 4, 2026 14:07
zoharma
force-pushed
the
zma/sidebar-nav-slots
branch
from
August 6, 2026 12:01
84ec600 to
03ac53d
Compare
zoharma
force-pushed
the
zma/sidebar-nav-slots
branch
from
August 6, 2026 12:29
03ac53d to
76d3cb3
Compare
Lets callers inject content after the nav items (inside the scrollable area) or pinned to the bottom of the drawer, e.g. secondary links or a settings/user menu. Also fixes long labels like "Data Browse" wrapping to two lines and inflating row height while the sidebar is collapsed. added open/close to stories
zoharma
force-pushed
the
zma/sidebar-nav-slots
branch
from
August 6, 2026 13:09
76d3cb3 to
6b9ca01
Compare
2 tasks
zoharma
changed the title
afterNavSlot and footerSlot to SidebarNav
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is built on top of #221
Described in #275
Lets callers inject content after the nav items (inside the scrollable area) or pinned to the bottom of the drawer, e.g. secondary links or a settings/user menu
Two smaller issues are fixed alongside this:
Long labels (e.g. "Data Browse") wrapped to two lines and inflated row height while the sidebar was collapsed.was fixed in New component: Initial SidebarNav implementation #221footerSlot.