Conversation
Unified hover built the bar swatch from pattern index 0. Use the hovered point index so color and pattern match that bar. Co-authored-by: CenFangyu <Dmao233@users.noreply.github.com>
The fork pull request number is now known. Co-authored-by: CenFangyu <Dmao233@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/fix-8008-bar-pattern-unified-hover-f220
branch
from
September 14, 2026 01:32
0f631c4 to
f341c93
Compare
Co-authored-by: CenFangyu <Dmao233@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified hover always drew the bar pattern swatch from index 0. The hovered point now supplies the pattern index, so the swatch matches that bar.
Fixes plotly#8008
The mock legend in
hovermode: 'x unified'reusedlegend/style.jsstyleBarLike. That path readmarker.patternat index 0 for every point. Color also stayed on the first bar becausecoercePatterncopiesmarker.colorintopattern.fgcoloras an array.This change:
indexwhen the legend is a unified hover mockThis pull request does not touch
dist/.Draftlog:
draftlogs/1_fix.mdTests:
hover_test.js(hovermode: (x|y)unified).I ran
npm run test-jasmine -- hover --nowatch --report-spec.The new spec
should style bar pattern swatches from the hovered pointpassed.Related specs for bar, funnel, and waterfall swatches also passed.
Eight other specs in that file failed. Those failures look unrelated to pattern swatches.
I did not inspect the rendered hover tooltip by eye. Please hover the issue figure and confirm the swatch.
🐦