Redirect conflict with uBlock Origin

[terrorist96]

Type: other

This extension failed to redirect a network request to https://s7.addthis.com/js/300/addthis_widget.js#pubid=tenthamendment because another extension (uBlock Origin) redirected it to chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/web_accessible_resources/af3c919ee9a3d97f5dedaf2f8bec146a.javascript?secret=qqesz4qhqw5h.

Looks like a surrogate redirect conflict?

@gorhill

[blackhelicoptersdotnet]

I'm getting the same, in my case with a Google Analytics URL.

Appeared today with version 2018.2.26

This extension failed to redirect a network request to https://www.google-analytics.com/analytics.js because another extension (uBlock Origin) redirected it to chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/web_accessible_resources/59fb24a2d12455d15bea20980e8a6801.javascript?secret=jblm6nqcej3g.

This extension failed to redirect a network request to https://s7.addthis.com/js/300/addthis_widget.js#pubid=ra-59c545b43f9cd35b because another extension (uBlock Origin) redirected it to chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/web_accessible_resources/af3c919ee9a3d97f5dedaf2f8bec146a.javascript?secret=nrw0ygwf8axk.

[gorhill]

gorhill/uBlock#1170 (comment)

[jeremyn]

@gorhill Your comment says "The resources used by uBO for redirection purpose are found in this file." but the linked file, https://github.com/gorhill/uBlock/blob/master/assets/ublock/resources.txt , doesn't exist anymore. Is there an equivalent?

[gorhill]

I corrected the link, the resource files have been moved to a different repo since I wrote this comment: https://github.com/uBlockOrigin/uAssets/blob/master/filters/resources.txt.

[jeremyn]

Thanks @gorhill .

As an enhancement for HTTPS Everywhere, we might take resources.txt and use it to create exceptions for the various rewrites it does. For example we could add a checkbox that says "Exclude uBlock Origin rewrites" which, if checked, will not rewrite the items in resources.txt, and instead let uBlock Origin handle them.

I'm not saying this is a good idea to do, but it's something that could be done.

[mystica555]

I would appreciate this 'resources.txt' as exeptions, because honestly I don't want https everywhere to be redirecting me to tracking sites I explicitly block with ublock; the way it works now, trackers totally being blocked from loading, is the preferred scenario. I just want the ! to disappear making me think there are 'actual' problems with https on the site I am visiting.

[jeremyn]

@terrorist96 @blackhelicopters @ariksc @mystica555 Can you all please edit your comments to provide a URL where you go to see the problem? Not the error from the developer console, but the URL in your browser's address bar.

[terrorist96]

I'll try to post it if I come across it again. BTW, here's the PR Privacy Badger made to avoid this issue from occurring:
EFForg/privacybadger#1905

[gorhill]

@jeremyn

we might take resources.txt and use it to create exceptions for the various rewrites it does

In that case resources.txt is not the right place for this, that would rather be the filters themselves, those with the redirect= option in any of the filter lists in https://github.com/uBlockOrigin/uAssets/tree/master/filters. There is a lots of these, and these lists are constantly edited. For the specific case here, this would be this filter:

||addthis.com/*/addthis_widget.js$script,redirect=addthis.com/addthis_widget.js

Which in plain language means: redirect all network requests for addthis_widget.js from addthis.com to a local, neutered version of the script.

[madusmacus]

This extension failed to redirect a network request to https://www.google-analytics.com/ga.js because another extension (uBlock Origin)

I have also had

This extension failed to redirect a network request to https://s7.addthis.com/js/300/addthis_widget.js#pubid=tenthamendment because another extension (uBlock Origin) redirected it to chrome-extension://cjpalhdlnbpafiamejdnhcphjbkeiagm/web_accessible_resources

[jeremyn]

@gorhill Thanks. So it sounds like the logic for us might be: go through the files in https://github.com/uBlockOrigin/uAssets/tree/master/filters , look for filter lines that start with || and include redirect=, and add those partial-URLs to a list controlled by the checkbox I suggested earlier at #14961 (comment).

Why is this issue popular suddenly? Did something change recently in uBlock Origin?

[gorhill]

Why is this issue popular suddenly? Did something change recently in uBlock Origin?

I wondered. uBO has supported redirection since quite a while now, to data: URIs. However in a recent release uBO will redirect to web accessible resources instead of data: URIs. This has changed to solve long standing issue gorhill/uBlock#2823. Not sure whether this is what is causing more reports about this -- redirecting to data: URIs was also causing such conflicts before (as pointed out at old issue gorhill/uBlock#1170).

[jeremyn]

All of the reports here so far are reporting redirects to something under web_accessible_resources, so the recent uBlock Origin change may be related. But it sounds like these reporters should have seen the same error before, except it would have been to data: instead of web_accessible_resources, right?