Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Disable on site feature does not work on same site with/ without tailing dots  #18451

Description

@cschanaj

Type: code issue

Platform

Firefox 69.0.1 on Ubuntu 19
HTTPS Everywhere 2019.6.27

Steps to reproduce

  1. Visit https://www.disabled-site-example.com./ (with tailing dots)
  2. Disable HTTPSE via the extension popup
  3. Visit http://www.disabled-site-example.com/ (without tailing dots)
  4. Open popup, observe "Disable HTTPS Everywhere on this site" button is present

Expected behaviour

  1. Open popup, observe "Enable HTTPS Everywhere on this site" button is present

Cause

Disabled site's hostname is not normalisd before being saved to extension storage. Sites with tailing dots are regarded as different, even they are not.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions