Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Re-enable Bit.ly vanity domains #4097

Description

@jsha

src/chrome/content/rules/Bit.ly_vanity_domains.xml has a lot of rules for Bit.ly vanity domains that we had to disable. They redirected vanity domains to bitly.com, which would fail horribly when the vanity domain moved off of bitly.

Now, it looks like many bitly domains have valid HTTPS certificates, so in theory this whole ruleset can be turned into a simple http->https rule.

To do this, (1) comment out all existing rules, and add an http->https rewrite. (2) run ./fetch-test.sh src/chrome/content/rules/Bit.ly_vanity_domains.xml and check which domains fail. Remove those domains from the target list.

We can probably also remove most of the special rewrites. Most of these are there because the root URL of a bitly vanity domain would general redirect to the owner, e.g. nyt.ms -> nytimes.com. With the simple http->https this is no longer necessary. Still, we should read each particular special rewrite and understand its purpose before removing it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions