Broken on Firefox Nightly

[gitarra]

Addon does not work on Firefox Nightly.

I am getting for syntax error in Browser Console.

https-everywhere/src/chrome/content/code/IOUtil.js

Line 130 in 445df15

for each(var cb in [channel.notificationCallbacks,

Disable non-standard for-each:
https://bugzilla.mozilla.org/show_bug.cgi?id=1293305

[jeremyn]

@Hainish Pinging you to make you aware of this. We don't want another #5874 .

[numismatika]

I have seen that the menu is partially broken on my FF53 nightly , the top half is gone. Might be related.
This should have at least 1 rule marked active in the menu. Even more depending on external ad load.

[jeremyn]

@smw-koops Does your pull request fix the problem @numismatika reported in the previous comment?

@jeremyn I don't know.

[numismatika]

Is there a way to make a beta test release to find out?

[jeremyn]

@numismatika Yes. You want to build an .xpi as described in the README.

[numismatika]

It doesn't like my Python Installation on Windows even if i try to install 2.7 again and lxml (which fails as well there).
On Linux it fails with various whitelisting issues. Can't you just merge it upstream and release it?
I don't think it would break.

[jeremyn]

@numismatika Development on Windows isn't really supported, see the discussion around #5584 (comment) . What problems are you having with Linux?

[AlexBeLi]

Maybe it make sense to use msys/msys2?

[jeremyn]

@AlexBeLi I don't think MSYS or Cygwin will work. I even tried the new Bash on Windows functionality a while ago (see #5584 (comment)) and that didn't work. I really recommend that anyone using Windows uses a Linux VM for HTTPS Everywhere development.

[numismatika]

fixes my issue.
I forgot to init the submodules before building the xpi, that's what broke it.

[jeremyn]

@numismatika So (re)running install-dev-dependencies.sh fixed the problem?