This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Closed
Conversation
added 2 commits
September 27, 2017 16:15
Contributor
|
Why do we run eslint inside docker, instead of in the git repo? |
Author
|
We mount |
added 2 commits
September 29, 2017 05:37
Author
Contributor
|
@koops76 sorry if my question was unclear. I'd like to know why we should dockerize this test? It seems like it adds an unnecessary layer of abstraction. |
Author
|
@cowlicks Speeds up the test, since we already have node dockerized, but we have to install ESLint each time. |
Contributor
|
@koops76 I'm working on a PR that will run eslint as an independent test in travis. So it won't run for every test in travis #12624 |
ghost
closed this
ghost
deleted the
docker-eslint
branch
October 1, 2017 05:11
Author
|
@cowlicks Closing until you finish. |
Author
|
Closing in favor of #12624. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping @Hainish @cowlicks.