Integrate Robinhood Chain - #6150
Conversation
d7f2c1a to
f77e4a7
Compare
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f77e4a7. Configure here.
Register the robinhood currency plugin so users can create a Robinhood Chain wallet. The chain badge is shown on the wallet icon because the native asset is ETH, which would otherwise be indistinguishable from Ethereum mainnet.
f77e4a7 to
030b1f7
Compare







Technical Design Document
robinhood-chain.md
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-currency-accountbased#1087 (the
robinhoodplugin itself)Requirements
If you have made any visual changes to the GUI. Make sure you have:
Description
Registers the
robinhoodcurrency plugin so users can create a Robinhood Chain wallet. Robinhood Chain is an Arbitrum L2 (EVM chain 4663) that uses ETH for gas.Asana: https://app.asana.com/1/9976422036640/project/1213843652804305/task/1217382370104887
Five files, matching the
opbnbandmonadregistrations:corePlugins.ts,envConfig.ts,WalletAndCurrencyConstants.ts, and the two locale files.WalletAndCurrencyConstants.tscarries two list entries, not one. BeyondWALLET_TYPE_ORDERand theSPECIAL_CURRENCY_INFOblock,robinhoodalso goes inCURRENCY_SETTINGS_KEYS, whichWalletSettingsModalreads to decide whether to show the Asset Settings row and whichAssetSettingsScenemaps to build its list. Every peer EVM L2 is in it. Bugbot caught the omission; the rest of the GUI's hardcoded pluginId lists were checked and correctly exclude this chain, since they are ramp and payment-protocol asset maps for providers that do not support it.showChainIcon: trueis the one entry worth a look. The native asset is ETH, so without the chain badge a Robinhood Chain wallet is indistinguishable from an Ethereum mainnet wallet in the wallet list.arbitrumandbaseset it for the same reason.The wallet name string is "My Robinhood Chain" rather than "My Robinhood", since the shorter form reads as a brokerage account.
Testing. Full jest suite, snapshots and eslint pass. Driven on the iOS simulator against EdgeApp/edge-currency-accountbased#1087 linked in: searching "Robinhood" in Choose Wallets to Add lists the chain, creating gives "My Robinhood Chain" on a wallet scene titled "Robinhood Chain Network", and importing a seed with real on-chain history renders its live balance. After the
CURRENCY_SETTINGS_KEYSfix, re-driven to confirm the wallet's Asset Settings row renders and "Robinhood Chain" appears in the Asset Settings list between Ravencoin and Rootstock. Screenshots are attached in comments below.One search behavior to know when testing:
filterWalletCreateItemListBySearchTextrequires every whitespace-separated term to prefix-match a field, so typing the full "Robinhood Chain" returns nothing while "Robinhood" matches.Follow-ups, neither blocking:
ROBINHOOD_INITneeds adding to the deployedenv.json, orasCorePluginInitreturnsfalseand the plugin ships disabled.content.edge.app/currencyIconsV3/robinhood/(robinhood.png,chain_robinhood.png) do not exist yet, so the wallet renders a text placeholder in the app.