🔧 #195 #196: Set router ctx in stream chunks & handle end of stream in case of some errors#203
Merged
Merged
Conversation
…nd error message types & removed all unneeded context from stream objects & defined a set of possible error codes
roma-glushko
added
type:enhancement
This was
linked to
issues
Apr 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #203 +/- ##
===========================================
- Coverage 67.34% 67.19% -0.15%
===========================================
Files 78 78
Lines 3586 3573 -13
===========================================
- Hits 2415 2401 -14
- Misses 1043 1045 +2
+ Partials 128 127 -1 ☔ View full report in Codecov by Sentry. |
roma-glushko
added a commit
to EinStack/glide-py
that referenced
this pull request
Apr 16, 2024
- adjusted all stream schemas to reflect changes in EinStack/glide#203 - raise client error if stream was interrupted by error - introduced finish_reason filed on the error schema to indicate fatal/terminal errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
Testing
glide-chat-stream-demo.mov