Build error on gcc 9.1 since #663

[apoelstra]

Reverting commit a9f589b9ecce8e0bb3f62dc2f03aea064469f147, part of #663, makes the build succeed.

Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/9.1.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /build/gcc/src/gcc/configure --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/ --enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++ --enable-shared --enable-threads=posix --with-system-zlib --with-isl --enable-__cxa_atexit --disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp --enable-gnu-unique-object --enable-linker-build-id --enable-lto --enable-plugin --enable-install-libiberty --with-linker-hash-style=gnu --enable-gnu-indirect-function --enable-multilib --disable-werror --enable-checking=release --enable-default-pie --enable-default-ssp --enable-cet=auto
Thread model: posix
gcc version 9.1.0 (GCC) 

  CXX      rpc/libbitcoin_server_a-rawtransaction.o
rpc/rawtransaction.cpp: In function 'UniValue rawblindrawtransaction(const JSONRPCRequest&)':
rpc/rawtransaction.cpp:2256:139: error: invalid initialization of reference of type 'const std::vector<std::pair<CScript, CScript> >&' from expression of type 'COutPoint'
 2256 |             if (tx.witness.vtxinwit.size() != tx.vin.size() || !IsValidPeginWitness(tx.witness.vtxinwit[nIn].m_pegin_witness, tx.vin[nIn].prevout, err, false)) {
In file included from rpc/rawtransaction.cpp:19:
./pegins.h:22:111: note: in passing argument 2 of 'bool IsValidPeginWitness(const CScriptWitness&, const std::vector<std::pair<CScript, CScript> >&, const COutPoint&, std::string&, bool)'
   22 | bool IsValidPeginWitness(const CScriptWitness& pegin_witness, const std::vector<std::pair<CScript, CScript>>& fedpegscripts, const COutPoint& prevout, std::string& err_msg, bool check_depth);
      |                                                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
make[2]: *** [Makefile:8689: rpc/libbitcoin_server_a-rawtransaction.o] Error 1
make[2]: Leaving directory '/home/apoelstra/dload/code/ElementsProject/elements/src'
make[1]: *** [Makefile:13556: all-recursive] Error 1
make[1]: Leaving directory '/home/apoelstra/dload/code/ElementsProject/elements/src'
make: *** [Makefile:783: all-recursive] Error 1

[instagibbs]

this appears to be a error for dynafed branch? const std::vector<std::pair<CScript, CScript>>& fedpegscripts isn't an arg in master(it's grabbed directly from chainparams)

[stevenroose]

@apoelstra like Greg mentions, the signature for IsValidPeginWitness in master is

bool IsValidPeginWitness(const CScriptWitness& pegin_witness, const COutPoint& prevout, std::string& err_msg, bool check_depth);

So that signature seems to have been changed in the dynafed branch then and that is causing the error?

[apoelstra]

Oh, yeah, I'm only testing on the dynafed branch. Let me compile on master to be sure.

[apoelstra]

Yeah passes on master. It's dynafed-only.

[instagibbs]

was some sort of rebase error on my part