rpc: expose effective fee asset - #1577
Merged
tomt1664 merged 1 commit intoAug 12, 2026
Merged
Conversation
delta1
approved these changes
Aug 11, 2026
Member
|
tACK 13d830f |
tomt1664
added a commit
to tomt1664/elements
that referenced
this pull request
Sep 3, 2026
…ive-fee-asset rpc: expose effective fee asset
tomt1664
added a commit
that referenced
this pull request
Sep 3, 2026
f80fb30 Merge #1589: simplicity: update subtree to abede47e (merge-script) 5b388c2 Merge pull request #1577 from Abdullah1738/feat/effective-fee-asset (Tom Trevethan) 48456e3 Add test that sighash midstate cache treats the SIGHASH_RANGEPROOF bit as part of its key (Tom Trevethan) d47af63 Merge #1584: script: add and default to SIGHASH_ALL_WITH_RANGEPROOF for pre-taproot signing (merge-script) 7c23bd1 blind: reject empty surjection-target set in SurjectOutput (Byron Hambly) 3e11e03 blindpsbt: require genuine commitments in VerifyBlindValueProof (Byron Hambly) 99e9f25 blindpsbt: require both range bounds to match claim in VerifyBlindValueProof (Byron Hambly) 8a08453 validation: always validate and retain dynafed header block_height (Byron Hambly) 4309282 dynafed: require at least four-fifths approval for parameter transition (Byron Hambly) 6a49991 blindpsbt: refuse to blind a PSET output with no amount (Byron Hambly) 0ce3c24 blindpsbt: reject off-curve blinding pubkey before ECDH (Byron Hambly) 2391041 blindpsbt: return error instead of asserting on surjection proof failure (Byron Hambly) 6253d7e fix: range proof cache bind to asset and scriptpubkey (Byron Hambly) 3d7134f Merge #1593: Fix RPC return errors for psbt and invalid rangeproofs (merge-script) Pull request description: ACKs for top commit: delta1: ACK f80fb30; tested locally Tree-SHA512: 42995e5b4842ce9694d9d5d30764230b774db24cda40d825742a174d564761e725a8323362404ee9653495936ab850c9933075b7ad924caa73768d0980bcbf96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Elements accepts
-feeasset=<asset-id>and uses the resultingpolicyAssetfor transaction-fee and relay policy, whilegetsidechaininfocurrently exposes only the consensuspegged_asset. An RPC client connected to an already-running node therefore cannot determine whether the operator selected a different effective fee asset.Change
fee_assetfield togetsidechaininfopolicyAssetafter startup argument processingpegged_assetfield unchangedThe change is additive and read-only.
policyAssetis fixed before RPC service starts, so it does not introduce new mutable state or locking.Local verification
rpc_sidechaininfo.pypassed directly and through the functional test runnerrpc_tweakfedpeg.py --legacy-walletpassedfeature_dynafed.py --legacy-walletpassed