tests: fix test_gossip_force_broadcast_channel_msgs flake - #9506
Open
daywalker90 wants to merge 1 commit into
Open
daywalker90 wants to merge 1 commit into
daywalker90 wants to merge 1 commit into
Conversation
Changelog-None
Andezion
reviewed
Sep 18, 2026
Andezion
left a comment
Andezion
left a comment
Collaborator
There was a problem hiding this comment.
as i see in the first gossipwith invocation, --max-messages and --timeout-after were both removed with nothing replacing them. I checked devtools/gossipwith.c with both flags at their defaults (max_messages = -1UL, timeout_after = -1), stream_stdin false, pollfd[0].fd is set to -1 up front, so the loop condition while (max_messages != 0 || pollfd[0].fd != -1) never becomes false and poll() blocks in definitely. so this gossipwith process now never exits on its own under normal test conditions? maybe we should add a time.sleep(some small value) followed by process.terminate()?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog-None
Fixes: #9270