Fix flaky Firefox E2E tests: async URL assertions and canvas animation wait#525
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tion wait Co-authored-by: gkorland <753206+gkorland@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix timeout errors in navbar external navigation tests on Firefox
Fix flaky Firefox E2E tests: async URL assertions and canvas animation wait
Mar 8, 2026
gkorland
approved these changes
Mar 8, 2026
gkorland
approved these changes
Mar 8, 2026
gkorland
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two navbar tests timeout on Firefox due to synchronous URL assertions firing before external navigation completes. One canvas zoom test is flaky because scaling values are read before the zoom animation settles.
e2e/tests/navBar.spec.tsexpect(page.url()).toBe(url)with Playwright's auto-retryingawait expect(page).toHaveURL(url)for the logo redirect test and thenavitemsloop testse2e/tests/canvas.spec.tsawait codeGraph.waitForCanvasAnimationToEnd()afterclickZoomIn()/clickZoomOut()calls in both zoom tests, before reading the updated canvas scaling values — consistent with how the same method is already used elsewhere in the fileOriginal prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.