Skip to content

Revert FalkorDBLite backend + MCP context benchmark (accidental #706 merge)#707

Closed
DvirDukhan wants to merge 1 commit into
stagingfrom
dvirdukhan/revert-706-falkordblite
Closed

Revert FalkorDBLite backend + MCP context benchmark (accidental #706 merge)#707
DvirDukhan wants to merge 1 commit into
stagingfrom
dvirdukhan/revert-706-falkordblite

Conversation

@DvirDukhan

@DvirDukhan DvirDukhan commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

What

Reverts the three commits that PR #706 (`naseem/falkordblite-mcp-latest`) accidentally introduced into `staging`:

  • `8ec9744` Add MCP context benchmark
  • `84ee21a` Document FalkorDBLite configuration
  • `eefaa40` Add FalkorDBLite backend support

Why

#706 was branched from the wrong base: it sat on top of the #701/#702 MCP work rather than `staging`. Its three unrelated commits (a new FalkorDBLite DB backend + an MCP context benchmark) rode into `staging` through the #702 merge instead of a dedicated, reviewed #706 merge — so a substantial, unreviewed feature landed by accident.

This PR reverts only those three commits. All #701/#702 MCP work (hybrid `search_code`, `get_neighbors`, `find_symbol`, drop-`ask`, review fixes) is untouched — it remains in `staging` via its own proper merges.

Validation

  • Revert applied with no conflicts.
  • No remaining references in `staging` to the reverted `api/db.py` / FalkorDBLite paths or the removed `benchmarks/mcp_context_benchmark.py`.
  • Touched `api/*` modules import and compile cleanly.
  • Net change: `+75 / -457` across 12 files (exact inverse of the three commits, incl. `pyproject.toml` + `uv.lock`).

If the FalkorDBLite backend is wanted, it should come back as its own PR branched from `staging` and reviewed on its own merits.

Summary by CodeRabbit

  • Documentation

    • Simplified setup instructions with direct FalkorDB configuration guidance.
    • Updated environment variable documentation, removing embedded backend options.
  • Chores

    • Removed embedded FalkorDBLite backend support.
    • Removed optional lightweight dependency package.
    • Removed benchmark script.
    • Streamlined database configuration to use only direct FalkorDB connections.

PR #706 (`naseem/falkordblite-mcp-latest`) was branched from the wrong
base: it sat on top of the #701/#702 MCP work and added three unrelated
commits that rode into `staging` through the #702 merge rather than a
dedicated, reviewed #706 merge. This reverts only those three accidental
commits, leaving all #701/#702 MCP work intact:

- 8ec9744 Add MCP context benchmark
- 84ee21a Document FalkorDBLite configuration
- eefaa40 Add FalkorDBLite backend support

No staging code references the reverted api/db.py / FalkorDBLite paths or
the removed benchmark; the touched api modules compile cleanly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread api/graph.py
import os
import re
import time
from .entities import *
Comment thread api/graph.py
params = {'path': path, 'name': name, 'ext': ext, 'coverage': coverage}

self._query(q, params)
res = self._query(q, params)
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f6a0e708-e98b-405d-9b3c-a7778dcce03e

📥 Commits

Reviewing files that changed from the base of the PR and between 04da6b4 and 984c7cf.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (11)
  • .env.template
  • README.md
  • api/cli.py
  • api/db.py
  • api/git_utils/git_graph.py
  • api/graph.py
  • api/info.py
  • api/llm.py
  • api/migrations/per_branch.py
  • benchmarks/mcp_context_benchmark.py
  • pyproject.toml

📝 Walkthrough

Walkthrough

The PR removes support for the embedded FalkorDBLite backend by deleting the api/db.py factory module and refactoring all modules to directly instantiate FalkorDB and Redis clients from environment variables, simplifying configuration and reducing optional dependencies.

Changes

Remove FalkorDBLite Backend Support

Layer / File(s) Summary
Documentation and configuration cleanup
.env.template, README.md, pyproject.toml
Environment template, setup instructions, and optional dependencies updated to remove FalkorDBLite references. FalkorDB host/port configuration remains with standard connection credentials documented.
CLI startup simplification
api/cli.py
ensure-db command no longer initializes embedded FalkorDBLite backend; proceeds directly to FalkorDB connectivity validation and Docker auto-start for local deployments.
Graph database connection refactoring
api/git_utils/git_graph.py, api/graph.py
GitGraph, AsyncGitGraph, and Graph classes construct FalkorDB/AsyncFalkorDB connections directly from FALKORDB_HOST, FALKORDB_PORT, FALKORDB_USERNAME, FALKORDB_PASSWORD environment variables instead of factory functions. Graph.get_sub_graph parameter renamed from limit to l.
Metadata and AI service connections
api/info.py, api/llm.py
Redis client creation in info.py and KnowledgeGraph instantiation in llm.py now directly use environment variables instead of factory abstractions, with decode_responses enabled for Redis.
Migration utilities
api/migrations/per_branch.py
Migration connection helper _connect() directly instantiates FalkorDB from environment variables with localhost/6379 defaults instead of using factory function.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Farewell to FalkorDBLite, so lightweight and small,
We've unwoven the factory, now connect direct to all.
From env vars we spring, with no indirection's chains—
One graph database path, through the app's veins.
Simpler configs emerge, as the deprecated fades away.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dvirdukhan/revert-706-falkordblite

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DvirDukhan

Copy link
Copy Markdown
Contributor Author

Closing — not needed. On closer analysis, the three commits this PR reverted (FalkorDBLite backend, its docs, and the MCP context benchmark) are wanted in staging. The other 5 commits #706 listed are byte-identical (same SHAs) to the #701/#702 work already properly merged, so #706 introduced no faulty or duplicate code — only those 3 net-new wanted commits. Keeping staging as-is.

@DvirDukhan DvirDukhan closed this Jun 9, 2026
@DvirDukhan DvirDukhan deleted the dvirdukhan/revert-706-falkordblite branch June 9, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant