Revert FalkorDBLite backend + MCP context benchmark (accidental #706 merge)#707
Revert FalkorDBLite backend + MCP context benchmark (accidental #706 merge)#707DvirDukhan wants to merge 1 commit into
Conversation
PR #706 (`naseem/falkordblite-mcp-latest`) was branched from the wrong base: it sat on top of the #701/#702 MCP work and added three unrelated commits that rode into `staging` through the #702 merge rather than a dedicated, reviewed #706 merge. This reverts only those three accidental commits, leaving all #701/#702 MCP work intact: - 8ec9744 Add MCP context benchmark - 84ee21a Document FalkorDBLite configuration - eefaa40 Add FalkorDBLite backend support No staging code references the reverted api/db.py / FalkorDBLite paths or the removed benchmark; the touched api modules compile cleanly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| import os | ||
| import re | ||
| import time | ||
| from .entities import * |
| params = {'path': path, 'name': name, 'ext': ext, 'coverage': coverage} | ||
|
|
||
| self._query(q, params) | ||
| res = self._query(q, params) |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
📝 WalkthroughWalkthroughThe PR removes support for the embedded FalkorDBLite backend by deleting the api/db.py factory module and refactoring all modules to directly instantiate FalkorDB and Redis clients from environment variables, simplifying configuration and reducing optional dependencies. ChangesRemove FalkorDBLite Backend Support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing — not needed. On closer analysis, the three commits this PR reverted (FalkorDBLite backend, its docs, and the MCP context benchmark) are wanted in |
What
Reverts the three commits that PR #706 (`naseem/falkordblite-mcp-latest`) accidentally introduced into `staging`:
Why
#706 was branched from the wrong base: it sat on top of the #701/#702 MCP work rather than `staging`. Its three unrelated commits (a new FalkorDBLite DB backend + an MCP context benchmark) rode into `staging` through the #702 merge instead of a dedicated, reviewed #706 merge — so a substantial, unreviewed feature landed by accident.
This PR reverts only those three commits. All #701/#702 MCP work (hybrid `search_code`, `get_neighbors`, `find_symbol`, drop-`ask`, review fixes) is untouched — it remains in `staging` via its own proper merges.
Validation
If the FalkorDBLite backend is wanted, it should come back as its own PR branched from `staging` and reviewed on its own merits.
Summary by CodeRabbit
Documentation
Chores