use useSyncExternalStore to sync data in useObservable - #583
Merged
Conversation
jhuleatt
force-pushed
the
jhuleatt-usesyncexternalstore
branch
from
June 29, 2023 20:57
bed1b6a to
1c2cb90
Compare
HYACCCINT
approved these changes
Jul 21, 2023
Co-authored-by: Cynthia Wang <44329917+HYACCCINT@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrating the core of ReactFire to
useSyncExternalStore, which is the recommended way to sync state between React and something external (in our case RxJS).The main changes are in
src/useObservable.tsandsrc/SuspenseSubject.ts.Also adds a test to
test/firestore.test.tsxto address #327.