Ensure we close the opened netCDF file in gmt_nc_is_cube#4777
Merged
Conversation
Member
Author
|
OK, well, alla tests pass as before and the only real difference is in gmt_nc_is_cube which now simply closes a file. So I think a harmless PR that will solve your problem once in master. Perhaps just approve. |
Member
|
I just realize that I can test it in PR #4745. Will report back in < 30 minutes. |
joa-quim
approved these changes
Feb 9, 2021
joa-quim
left a comment
joa-quim
left a comment
Member
There was a problem hiding this comment.
Confirmed that it works. Uf.
Member
Author
|
Did this do the trick, @seisman ? |
Member
|
It works for the simple tests in PR #4745, but I need to wait for conda-forge to run the full PyGMT tests. |
Member
Author
|
OK, I assume that will work fine since we clearly fixed the bug with the missing close. But post if any surprises are found. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The (new) gmt_nc_is_cube function prematurely returned without closing the door. Closes #4745.