Skip to content

Ensure plotting xarray grids with different central meridians work on some projections#560

Merged
weiji14 merged 19 commits into
masterfrom
test/central_meridians
Sep 11, 2020
Merged

Ensure plotting xarray grids with different central meridians work on some projections#560
weiji14 merged 19 commits into
masterfrom
test/central_meridians

Conversation

@weiji14

@weiji14 weiji14 commented Aug 10, 2020

Copy link
Copy Markdown
Member

Description of proposed changes

Adds tests to make sure that plotting xarray.DataArray grids at different central meridians work properly for different projection types. See #515 (comment) for background context. Note that this depends on GMT >= 6.1.1 and won't work yet.

Reverts the runfirst workaround required in #476, reverts #531 grdtrack gallery example crash on macOS due to a problematic meridian setting.

Note that this PR may depend on #555 ✔️

Addresses #390, Fixes #515

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Global earth relief data loaded as xarray doesn't work if projection center is not 0

3 participants