Ensure plotting xarray grids with different central meridians work on some projections#560
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adds tests to make sure that plotting
xarray.DataArraygrids at different central meridians work properly for different projection types. See #515 (comment) for background context. Note that this depends on GMT >= 6.1.1 and won't work yet.Reverts the
runfirstworkaround required in #476, reverts #531 grdtrack gallery example crash on macOS due to a problematic meridian setting.Note that this PR may depend on #555 ✔️
Addresses #390, Fixes #515
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.