Wrap grdinfo aliases#799
Conversation
…le; changing units from US to SI
# Conflicts: # examples/projections/cyl/cyl_transverse_mercator.py # examples/projections/cyl/cyl_universal_transverse_mercator.py
|
@seisman I think I have taken care of all of your recommended changes |
weiji14
left a comment
weiji14
left a comment
There was a problem hiding this comment.
Just some more minor suggestions :)
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
|
@willschlitzer, could you squash and merge this yourself? Remember to summarize the commit message! |
|
@GenericMappingTools/python It looks like this keeps failing Windows tests (but not the same tests). Is there a particular method we use to squash and merge, or should I just follow the command line instructions that GitHub recommends? |
It's ok to ignore the random Windows test failures (we've been trying unsuccessfully to debug and fix it for a while now, see #758).
Just use the Github UI (i.e. click the 'squash and merge' button). Do not use the command line instructions as it does a slightly different thing. I'll disable the required Windows checks so you can merge (after resolving the conflict on |
|
/format |
*Wrap grdinfo R, C, D, F, I, L, T, and M aliases *Move grdinfo function to grdinfo.py Co-authored-by: Dongdong Tian <seisman.info@gmail.com> Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
4 participants
Wrapping the R, C, D, F, I, L, T, and M aliases for grdinfo. This is the first part of improving grdinfo, as mentioned in #593 , and once this is done I intend to create an argument to return a dictionary of the grdinfo values.
Ref GMT.jl at https://www.generic-mapping-tools.org/GMT.jl/v0.28/#GMT.grdinfo
Documentation preview is at https://pygmt-git-fork-willschlitzer-grdinfo-alias.gmt.vercel.app/api/generated/pygmt.grdinfo.html#pygmt.grdinfo