Skip to content

fix(llc): require attachment fileSize only when there is a file #2673

Merged
renefloor merged 2 commits into
v10.0.0from
fix/attachment-file-size-requirement
May 20, 2026
Merged

fix(llc): require attachment fileSize only when there is a file #2673
renefloor merged 2 commits into
v10.0.0from
fix/attachment-file-size-requirement

Conversation

@Brazol
Copy link
Copy Markdown
Contributor

@Brazol Brazol commented May 20, 2026

Submit a pull request

Linear: FLU-

Github Issue: #

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Screenshots / Videos

Before After
img img

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5bc326bc-4bf6-48a6-9289-19b160d05d3f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/attachment-file-size-requirement

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

…picker/stream_attachment_picker_controller.dart

Co-authored-by: Rene Floor <rene.floor@getstream.io>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (v10.0.0@b73bb71). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...nt_picker/stream_attachment_picker_controller.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v10.0.0    #2673   +/-   ##
==========================================
  Coverage           ?   66.64%           
==========================================
  Files              ?      404           
  Lines              ?    24108           
  Branches           ?        0           
==========================================
  Hits               ?    16067           
  Misses             ?     8041           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@renefloor renefloor merged commit 3e5f7d8 into v10.0.0 May 20, 2026
8 of 9 checks passed
@renefloor renefloor deleted the fix/attachment-file-size-requirement branch May 20, 2026 12:24
@xsahil03x xsahil03x mentioned this pull request May 28, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants