Skip to content

List Bedrock models dynamically#38

Merged
intel352 merged 2 commits into
masterfrom
fix/dynamic-bedrock-model-listing
Jul 6, 2026
Merged

List Bedrock models dynamically#38
intel352 merged 2 commits into
masterfrom
fix/dynamic-bedrock-model-listing

Conversation

@intel352

@intel352 intel352 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a settings-aware model listing entrypoint while preserving the existing ListModels API
  • use the AWS Bedrock ListFoundationModels API to enumerate Anthropic text models for anthropic_bedrock
  • keep Azure/Vertex/Foundry on explicit manual-model errors until their required control-plane credential shapes are represented

References

Tests

  • go test ./provider -count=1
  • go test ./...

Copilot AI review requested due to automatic review settings July 6, 2026 08:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a settings-aware model listing entrypoint and implements dynamic model discovery for the anthropic_bedrock provider by calling AWS Bedrock’s ListFoundationModels API, while keeping other hosted variants on the “manual model ID” path until their credential shapes are supported.

Changes:

  • Added ListModelsWithSettings(...) and threaded provider settings through ModelListRequest.
  • Implemented Bedrock-backed dynamic model discovery for anthropic_bedrock using ListFoundationModels filtering for Anthropic text/on-demand models.
  • Added/updated tests for Bedrock listing behavior and updated AWS SDK dependencies to include the Bedrock service client.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
provider/models.go Adds a settings-aware listing entrypoint and implements Bedrock model discovery via AWS SDK.
provider/models_dynamic_test.go Updates hosted-provider “dynamic catalog required” expectations to exclude Bedrock (now supported).
provider/bedrock_models_test.go Introduces unit tests for Bedrock model listing behavior.
go.mod Adds service/bedrock and bumps AWS SDK versions.
go.sum Updates module checksums for the AWS SDK changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread provider/models.go
Comment thread provider/bedrock_models_test.go
@intel352
intel352 merged commit 79119e3 into master Jul 6, 2026
5 checks passed
@intel352
intel352 deleted the fix/dynamic-bedrock-model-listing branch July 6, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants