List Bedrock models dynamically#38
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a settings-aware model listing entrypoint and implements dynamic model discovery for the anthropic_bedrock provider by calling AWS Bedrock’s ListFoundationModels API, while keeping other hosted variants on the “manual model ID” path until their credential shapes are supported.
Changes:
- Added
ListModelsWithSettings(...)and threaded provider settings throughModelListRequest. - Implemented Bedrock-backed dynamic model discovery for
anthropic_bedrockusingListFoundationModelsfiltering for Anthropic text/on-demand models. - Added/updated tests for Bedrock listing behavior and updated AWS SDK dependencies to include the Bedrock service client.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| provider/models.go | Adds a settings-aware listing entrypoint and implements Bedrock model discovery via AWS SDK. |
| provider/models_dynamic_test.go | Updates hosted-provider “dynamic catalog required” expectations to exclude Bedrock (now supported). |
| provider/bedrock_models_test.go | Introduces unit tests for Bedrock model listing behavior. |
| go.mod | Adds service/bedrock and bumps AWS SDK versions. |
| go.sum | Updates module checksums for the AWS SDK changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References
Tests