feat: add ethereum validator reward provider#7
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Ethereum testnet-only “validator reward proof” provider to the public crypto catalog, including schemas/contracts, evidence validation, a runnable Go-based provider runner, and release packaging (binary + GHCR runtime image).
Changes:
- Introduces provider/operation JSON Schemas and a provider contract for
ethereum-testnet-validator-reward. - Extends the catalog evidence model + validation to include
ethereum_testnet_validator_rewardoperational evidence. - Adds a Go runner (with
--probe, fixture mode, live Beacon API balance delta observation) plus tests and release pipeline updates (GoReleaser + runtime image build/push).
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| schemas/ethereum-validator-reward-provider.schema.json | Provider runtime config schema for the validator reward provider. |
| schemas/ethereum-validator-reward-operation-input.schema.json | Operation input schema (includes fixture + live observation inputs). |
| schemas/ethereum-validator-reward-operation-output.schema.json | Operation output schema for produced artifacts. |
| contracts/ethereum-validator-reward-provider.json | Provider contract artifact wiring schemas, digests, operation, and runtime profile. |
| plugin.json | Exposes the new contract in the plugin manifest. |
| plugin.contracts.json | Exposes the new contract in the contracts manifest. |
| README.md | Documents the new provider role/evidence and the runtime component identifier. |
| catalog/crypto.go | Adds the new role/profile, bounded-work plumbing, digests, and contract/product generation updates. |
| catalog/evidence.go | Adds evidence struct/constants + validator for testnet validator reward evidence; extends raw-secret field detection. |
| catalog/evidence_test.go | Adds coverage for validator reward evidence validation and secret-field rejection behavior. |
| internal/validatorreward/provider.go | New runner implementation (probe, envelope parsing, fixture/live observe, evidence generation, blocker artifact). |
| internal/validatorreward/provider_test.go | Tests dynamic envelope fixture mode, live Beacon API observation, and mainnet rejection + blocker artifact. |
| internal/validatorreward/contract_test.go | Verifies contract artifact aligns with catalog output and schema digests; checks manifests expose contract refs. |
| cmd/ethereum-validator-reward-runner/main.go | Entrypoint binary for the validator reward runner. |
| docker/ethereum-validator-reward/Dockerfile | Distroless runtime image for the runner binary. |
| internal/plugin_test.go | Updates stable manifest expectations to include the new role/evidence contract ordering and digest. |
| .goreleaser.yaml | Adds a new build target and archives the new contract + schema artifacts. |
| .github/workflows/release.yml | Adds GHCR runtime image build/push job for the runner image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+367
to
+369
| if base.Scheme != "https" && base.Scheme != "http" { | ||
| return liveObservation{}, errors.New("beacon_api_url must use http or https") | ||
| } |
Comment on lines
+302
to
+306
| window := workload.ObservationWindowSeconds | ||
| if window <= 0 { | ||
| window = defaultObservationWindow | ||
| } | ||
| observation, err := observe(workload, window) |
Comment on lines
+80
to
+84
| "required": [ | ||
| "chain", | ||
| "network", | ||
| "validator_client_identity_ref", | ||
| "signer_mode_ref", |
intel352
marked this pull request as ready for review
June 24, 2026 07:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provider://workflow-plugin-crypto/ethereum/validator-reward-runner.--probe, explicit fixture mode, live beacon balance observation, blocker artifacts, and secret-field rejection.Boundaries
Verification