Extract GitHub runner job under workspace#34
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions runner-job image to extract the bundled runner into the workflow-compute writable mount (/workspace) instead of /home/runner, ensuring compatibility with read-only root filesystem sandboxing.
Changes:
- Move the runner extraction target to
/workspace/.github-actions-runner(Dockerfile + entrypoint default). - Set container
WORKDIRto/workspacefor sandbox compatibility. - Strengthen release packaging tests to prevent regressions back to
/home/runnerand assert required entrypoint behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| release_packaging_test.go | Updates packaging assertions to enforce /workspace runner dir and reject /home/runner regressions. |
| cmd/github-actions-runner-job/entrypoint.sh | Defaults runner extraction directory to /workspace/.github-actions-runner and ensures parent exists before extraction. |
| cmd/github-actions-runner-job/Dockerfile | Switches WORKDIR and default GITHUB_ACTIONS_RUNNER_DIR to /workspace paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
intel352
marked this pull request as ready for review
June 29, 2026 06:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/workspace/.github-actions-runnerinstead of/home/runner/actions-runner/workspace:rwmount/home/runnerRoot cause
Retained STG Linux diagnostics showed the provider-owned runner image started under workflow-compute, then failed in the entrypoint with:
The dynamic provider sandbox uses a read-only root filesystem and a writable
/workspacemount, so runner extraction must happen under/workspace.TDD / regression proof
With the packaging test updated first and the Dockerfile/entrypoint reverted to
/home/runner, the focused test failed with the expected missing/workspaceassertion.With the fix restored:
Runtime launch validation
Ran the real image locally with the workflow-compute sandbox shape:
Evidence:
/workspace/.github-actions-runner/config.sh/workspace/.github-actions-runner/run.shAdversarial self-review
USERwith host UID/GID; the launch validation includes that shape.WORKDIR /home/runnerand the oldGITHUB_ACTIONS_RUNNER_DIRfallback.