fix: bound runner shutdown waits#43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
GOWORK=off go test ./cmd/github-actions-runner-job -run 'TestT915WaitForGitHubCompletionDoesNotBlockOnRunnerShutdownAfterTerminalSuccess|TestT915CommandTreatsGitHubJobAPIAsCompletion|TestT915CommandTreatsRunnerSuccessMarkerAsCompletion|TestT915CommandRejectsFailedGitHubJobAPICompletion|TestT915CommandRejectsRunnerExitBeforeGitHubJobTerminal|TestT915CommandAllowsBriefGitHubJobAPICompletionLagAfterRunnerExit' -count=1PASSGOWORK=off go test ./cmd/github-actions-runner-job -run 'TestT915WaitForGitHubCompletionDoesNotBlockOnRunnerShutdownAfterTerminalSuccess|TestT915WaitForGitHubCompletionDoesNotBlockOnRunnerShutdownAfterTimeout|TestT915CommandTreatsGitHubJobAPIAsCompletion|TestT915CommandTreatsRunnerSuccessMarkerAsCompletion|TestT915CommandRejectsFailedGitHubJobAPICompletion|TestT915CommandRejectsRunnerExitBeforeGitHubJobTerminal|TestT915CommandAllowsBriefGitHubJobAPICompletionLagAfterRunnerExit' -count=1PASSGOWORK=off go test ./cmd/github-actions-runner-job -count=1PASSGOWORK=off go test ./internal -run 'EphemeralRunner|RunnerProvider|GitHubRunner' -count=1PASSGOWORK=off go test ./... -count=1PASSRevert Proof
With terminal-success bounded wait reverted:
GOWORK=off go test ./cmd/github-actions-runner-job -run TestT915WaitForGitHubCompletionDoesNotBlockOnRunnerShutdownAfterTerminalSuccess -count=1FAIL:waitForGitHubCompletion blocked on runner shutdown after terminal successWith timeout bounded wait reverted:
GOWORK=off go test ./cmd/github-actions-runner-job -run TestT915WaitForGitHubCompletionDoesNotBlockOnRunnerShutdownAfterTimeout -count=1FAIL:waitForGitHubCompletion blocked on runner shutdown after timeoutWith fixes restored:
./...suite pass.STG Evidence Context
github-provider-dogfood-linux-20260630182045reachedleasedwith zero proofs while target workflow28466630619completed successfully on the ephemeral provider runner. This PR addresses the provider finalization hang that prevents returninggithub-runner-proof.jsonto workflow-compute.