fix: align app deploy output schema#989
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an output-schema mismatch for the step.app_deploy pipeline step by emitting the deployed boolean at runtime, aligning the actual step output with the advertised step schema, and adds a regression assertion to prevent future drift.
Changes:
- Add
"deployed": truetostep.app_deployruntime output when deployment succeeds (i.e., returns no error). - Add a regression assertion verifying
deployed=truein the app deploy step factory test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| module/pipeline_step_app.go | Adds the missing deployed boolean to the app_deploy step output map to match the documented schema. |
| module/app_container_test.go | Adds a regression assertion ensuring deployed is present and true in the step output. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deployed: trueruntime output fromstep.app_deployso it matches the advertised step schema.Verification
GOWORK=off go test ./module -run 'TestAppContainer_AppDeployStepFactory' -count=1failed withexpected deployed=true, got <nil>.GOWORK=off go test ./module -run 'TestAppContainer_AppDeployStepFactory|TestAppContainer_AppDeployStepSpecFrom' -count=1passed.GOWORK=off go test ./module ./schema ./cmd/wfctl -count=1git diff --checkContext
This addresses a late Copilot review finding from workflow#988 that was discovered as #988 merged.