chore: bump modular to v1.13.5#998
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps the root Workflow module’s github.com/GoCodeAlone/modular dependency from v1.13.4 to v1.13.5 so the next Workflow release can pick up Modular’s latest fixes (notably the lock-across-I/O changes referenced in the PR description).
Changes:
- Update
go.modto requiregithub.com/GoCodeAlone/modular v1.13.5 - Refresh
go.sumentries for the new Modular version and checksum
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates the root module requirement to modular v1.13.5. |
| go.sum | Updates checksums to match the modular v1.13.5 dependency resolution. |
⏱ Benchmark Results✅ No significant performance regressions detected. benchstat comparison (baseline → PR)
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/GoCodeAlone/modulardependency from v1.13.4 to v1.13.5go.sumfor the new Modular release checksumWhy
Issue #133 follow-up found that
workflow v0.85.1was still built againstmodular v1.13.4. This patch lets the next Workflow release carry the Modular lock-across-I/O fixes into downstream plugin builds.Validation
GOWORK=off go test ./module ./plugin ./plugin/external ./platform/state ./platform/providers/dockercompose -count=1git diff --check