Skip to content

minor: Update title to reflect compute platform#2318

Merged
JustinBeckwith merged 1 commit into
mainfrom
topic/websockets-run
Aug 23, 2021
Merged

minor: Update title to reflect compute platform#2318
JustinBeckwith merged 1 commit into
mainfrom
topic/websockets-run

Conversation

@glasnt

@glasnt glasnt commented Aug 23, 2021

Copy link
Copy Markdown
Contributor

To reduce user confusion, this minor change ensures the compute platform being used for this sample matches the title of the sample app.

cc @averikitsch

@glasnt glasnt requested a review from a team as a code owner August 23, 2021 00:53
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 23, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2021

@iennae iennae left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I don't see why the one test is failing though.

@glasnt

glasnt commented Aug 23, 2021

Copy link
Copy Markdown
Contributor Author

Appears to be a failing test for an unmerged sample

(fusion reports missing file that doesn't exist in the main branch)

com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration file storage-streaming.cfg or storage-streaming.gcl under /tmp/workspace/workspace/cloud-devrel/nodejs-docs-samples/presubmit/run/storage-streaming/src/github/nodejs-docs-samples/.kokoro/run.

@JustinBeckwith JustinBeckwith merged commit 3b083ae into main Aug 23, 2021
@JustinBeckwith JustinBeckwith deleted the topic/websockets-run branch August 23, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants