Node deletion is too greedy

[Keavon]

Deleting the selected "Equals" node:

Incorrectly results in the overzealous deletion of its upstream nodes despite their usage by other nodes.

This doesn't match the desired deletion-with-cleanup behavior. CtrlDelete can be used in this situation to delete only itself, but we need the normal behavior to work in this circumstance.

[Abhinavpatel00]

changing

https://github.com/GraphiteEditor/Graphite/blob/a29802de366a1f0ca8446b282404bf15eb6f45e2/editor/src/messages/input_mapper/input_mappings.rs#L69

this to delete_children = false would fix the problem! should i add it in my PR? or would it break anything?

[Keavon]

That would disable the feature, not fix the feature's erroneous behavior.

[Daniel53245]

I believe it is the problem in selecting the child nodes.
Doing some modification on https://github.com/GraphiteEditor/Graphite/blob/3d37ef79acdbb5f97fea0d046e5dad8ea22cf07a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs#L271/
might be working. I will see if I could fix it.

[Daniel53245]

I believe this function is responsible for searching nodes to delete /
https://github.com/GraphiteEditor/Graphite/blob/d39308c048cc439715943ff487294ffccaf12c70/editor/src/messages/portfolio/document/utility_types/network_interface.rs#L4177//

I am still trying to understand it and see if there is a way to change the behavior in the mentioned node graph