Skip to content

Change selection to only the duplicated layer (not both layers) when using Ctrl+D #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keavon merged 8 commits into from
Apr 16, 2023
Merged

Change selection to only the duplicated layer (not both layers) when using Ctrl+D #1118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a77f697
Nudging is now based on local pixel dimensions
ChrisMend19 Apr 12, 2023
a2d9cd3
Brush tool live preview (#1116)
0HyperCube Apr 12, 2023
5aef3a0
Merge remote-tracking branch 'origin/master' into nudging_pixels_by_v…
ChrisMend19 Apr 12, 2023
9c989f8
Duplicating a layer selects only new layer
ChrisMend19 Apr 13, 2023
4ead72e
Merge remote-tracking branch 'origin/master' into duplicating_layers
ChrisMend19 Apr 13, 2023
3db0182
Merge remote-tracking branch 'origin/master' into duplicating_layers
ChrisMend19 Apr 15, 2023
a8fc16f
Merge branch 'master' into duplicating_layers
Keavon Apr 16, 2023
40bfc14
Add Ctrl+J duplicate alias hotkey
Keavon Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions editor/src/messages/input_mapper/default_mapping.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ pub fn default_mapping() -> Mapping {
entry!(KeyDown(KeyA); modifiers=[Accel], action_dispatch=DocumentMessage::SelectAllLayers),
entry!(KeyDown(KeyS); modifiers=[Accel], action_dispatch=DocumentMessage::SaveDocument),
entry!(KeyDown(KeyD); modifiers=[Accel], action_dispatch=DocumentMessage::DuplicateSelectedLayers),
entry!(KeyDown(KeyJ); modifiers=[Accel], action_dispatch=DocumentMessage::DuplicateSelectedLayers),
entry!(KeyDown(KeyG); modifiers=[Accel], action_dispatch=DocumentMessage::GroupSelectedLayers),
entry!(KeyDown(KeyG); modifiers=[Accel, Shift], action_dispatch=DocumentMessage::UngroupSelectedLayers),
entry!(KeyDown(KeyN); modifiers=[Accel, Shift], action_dispatch=DocumentMessage::CreateEmptyFolder { container_path: vec![] }),
Expand Down
2 changes: 2 additions & 0 deletions editor/src/messages/portfolio/document/document_message_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,8 @@ impl MessageHandler<DocumentMessage, (u64, &InputPreprocessorMessageHandler, &Pe
}
DuplicateSelectedLayers => {
self.backup(responses);
responses.push_front(SetSelectedLayers { replacement_selected_layers: vec![] }.into());
self.layer_range_selection_reference.clear();
for path in self.selected_layers_sorted() {
responses.push_back(DocumentOperation::DuplicateLayer { path: path.to_vec() }.into());
}
Expand Down
8 changes: 4 additions & 4 deletions node-graph/gcore/src/raster/brightness_contrast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,10 @@ mod tests {
#[allow(unused_imports)]
use crate::value::ClonedNode;

fn string_data(string: &str) -> Vec<u8> {
string.split(',').map(|s| s.parse().unwrap()).collect::<Vec<u8>>()
}

#[test]
fn brightness_contrast_legacy_tests() {
let string_data = |string: &str| string.split(',').map(|s| s.parse().unwrap()).collect::<Vec<u8>>();

let brightness_contrast_legacy_map = |brightness, contrast| -> [u8; 256] {
let brightness = ClonedNode::new(brightness);
let contrast = ClonedNode::new(contrast);
Expand Down Expand Up @@ -300,6 +298,8 @@ mod tests {

#[test]
fn brightness_contrast_tests() {
let string_data = |string: &str| string.split(',').map(|s| s.parse().unwrap()).collect::<Vec<u8>>();

let brightness_contrast_map = |brightness, contrast| -> [u8; 1024] {
let brightness = ClonedNode::new(brightness);
let contrast = ClonedNode::new(contrast);
Expand Down