Skip to content

New nodes: Resample Points, Spline from Points - #1226

Merged
Keavon merged 29 commits into
masterfrom
Resample-Curve-Node
Aug 30, 2023
Merged

New nodes: Resample Points, Spline from Points#1226
Keavon merged 29 commits into
masterfrom
Resample-Curve-Node

Conversation

@Chase-Percy

@Chase-Percy Chase-Percy commented May 20, 2023 •
edited by Keavon
Loading

Copy link
Copy Markdown
Contributor

Part of #912

@Chase-Percy Chase-Percy self-assigned this May 20, 2023
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 20, 2023 01:31 Inactive
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented May 20, 2023 •
edited
Loading

Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 16f3ac1
Status: ✅  Deploy successful!
Preview URL: https://82282a97.graphite.pages.dev
Branch Preview URL: https://resample-curve-node.graphite.pages.dev

View logs

@github-actions

github-actions Bot commented May 20, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview ready!

Name Link
🔨 Latest commit 16f3ac1
🔍 Latest deploy log https://github.com/GraphiteEditor/Graphite/actions/runs/5119544108
😎 Deploy Preview Url https://82282a97.graphite.pages.dev
🌳 Environment preview

@Keavon Keavon changed the title Resample Curve Node Resample as Polyline node May 20, 2023
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 21, 2023 01:14 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 21, 2023 01:28 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 21, 2023 01:49 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 21, 2023 02:28 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 22, 2023 08:24 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 25, 2023 11:18 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 25, 2023 11:30 Inactive
@Chase-Percy
Chase-Percy force-pushed the Resample-Curve-Node branch from 085a26e to b6c1dc4 Compare May 25, 2023 11:36
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 25, 2023 11:37 Inactive
@Chase-Percy
Chase-Percy force-pushed the Resample-Curve-Node branch from b6c1dc4 to a176b36 Compare May 25, 2023 12:06
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 25, 2023 12:08 Inactive
@Chase-Percy
Chase-Percy force-pushed the Resample-Curve-Node branch from a176b36 to 0d3bf7c Compare May 25, 2023 12:11
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 25, 2023 12:13 Inactive
@Chase-Percy
Chase-Percy force-pushed the Resample-Curve-Node branch from 0d3bf7c to fc54dce Compare May 29, 2023 08:44
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 29, 2023 08:46 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 29, 2023 10:24 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) May 30, 2023 09:00 Inactive
@Keavon

Keavon commented Jul 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Hi, can you please remind (or update) me of the status of this PR? Thanks!

@Chase-Percy

Chase-Percy commented Jul 8, 2023

Copy link
Copy Markdown
Contributor Author

Hi, can you please remind (or update) me of the status of this PR? Thanks!

Hey sorry just saw this. The last update I had is in the discord task help section. It's mostly done except for an edge case I posted about.

@Keavon
Keavon force-pushed the Resample-Curve-Node branch from 16f3ac1 to d86bf09 Compare July 30, 2023 09:31
@Keavon
Keavon force-pushed the master branch 2 times, most recently from 6fd55aa to a85174f Compare August 10, 2023 17:42
@Keavon
Keavon force-pushed the Resample-Curve-Node branch from 83cf4a0 to d8cdd81 Compare August 27, 2023 07:18
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 27, 2023 07:20 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 27, 2023 07:26 Inactive
@Keavon Keavon changed the title Resample as Polyline node New node: Resample as Polyline Aug 27, 2023
@Keavon

Keavon commented Aug 27, 2023

Copy link
Copy Markdown
Member

The fact that this works on text now makes this my favorite node!

image

But unfortunately it seems to be broken for shapes created with these tools:

  • Line
  • Rectangle
  • Ellipse
  • Polygon

The others work, even with closed shapes. @0HyperCube do you have any ideas why that might be?

@0HyperCube

0HyperCube commented Aug 27, 2023

Copy link
Copy Markdown
Contributor

@Keavon Works fine. Note that the spacing is specified in vector data space so the rectangle / line / ellipse / polygon which are unit size require a spacing of <1.

@Keavon

Keavon commented Aug 27, 2023

Copy link
Copy Markdown
Member

@0HyperCube Oh, I see. Would that be difficult to solve by making it use the current transform?

@Keavon
Keavon force-pushed the master branch 2 times, most recently from 4b4a168 to 37fe365 Compare August 29, 2023 23:07
@0HyperCube 0HyperCube mentioned this pull request Aug 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keavon Keavon Keavon approved these changes

Assignees

@Chase-Percy Chase-Percy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Chase-Percy @Keavon @0HyperCube