Fix regression causing pasted images to have a zero-size transform - #2238
Merged
Merged
Conversation
…g to keep ZERO not IDENTITY as the default image size
Keavon
force-pushed
the
image-frame-identity
branch
from
January 29, 2025 20:58
13b1324 to
029aede
Compare
Keavon
changed the title
Keavon
approved these changes
Jan 29, 2025
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where new images weren't appearing because the default was set to a zero matrix. A regression introduced by #2230 which made use of the default values of the image frame.
I'm not sure why this default would ever be useful? In any case it is probably more sensible to make it the identity.