Instance tables refactor part 3: flatten ImageFrame<P> in lieu of Image<P> - #2256
Merged
Merged
Conversation
Keavon
changed the title
Keavon
marked this pull request as ready for review
February 3, 2025 11:03
9 tasks
Keavon
force-pushed
the
instance-tables-pt3
branch
from
February 3, 2025 11:22
b36f57f to
7b64c73
Compare
Keavon
force-pushed
the
instance-tables-pt3
branch
from
February 4, 2025 21:59
39f98b1 to
7b64c73
Compare
Keavon
marked this pull request as draft
February 5, 2025 06:52
Keavon
force-pushed
the
instance-tables-pt3
branch
from
March 2, 2025 08:53
7b64c73 to
1771b3c
Compare
Keavon
marked this pull request as ready for review
March 2, 2025 09:09
Member
Author
|
Merging with one known issue:
This occurs while upgrading a previous document that contains Brush tool strokes. It doesn't seem to actually affect things, except for the fact that it alters the bounding box of the brush strokes to extend to the origin. After saving and reloading the upgraded document, that remains true but the console error doesn't return. Since brushes are not fully supported and usage is likely to be rare, I'm not going to investigate and try to fix this. |
Keavon
force-pushed
the
instance-tables-pt3
branch
from
March 2, 2025 09:31
cb1dbdf to
39cf18d
Compare
Keavon
added a commit
that referenced
this pull request
Mar 6, 2025
…ge<P> (#2256) * Remove ImageFrame<T> by flattening it into Image<T> * Rename TextureFrame to ImageTexture * Fix tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3, partly closes #1834.
Flattens the one-field
ImageFrame<P>struct, removing it to putImage<P>in its place.This PR is based on top of #2249. The first commit in the chain of this PR's changes is b36f57f. This PR is blocked on that PR being merged first.