Simplify and standardize how data types are presented in user-facing strings - #4147
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the display of data types in tooltips by removing the 'Data Type:' prefix and centralizing type formatting in the backend. Key changes include the introduction of a more robust make_type_user_readable function that handles type aliases and converts List<T> to T[] syntax, alongside optimizations in the network interface utility. Feedback was provided regarding a potential bug in the UTF-8 handling of the new string manipulation logic, where byte-level iteration could corrupt multi-byte characters.
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Confidence score: 4/5
- This PR looks safe to merge with minimal risk: the only reported issue is moderate (4/10) and localized rather than broadly destabilizing.
- In
node-graph/libraries/core-types/src/types.rs, buildingcharvalues byte-by-byte can corrupt non-ASCII type names, which may cause incorrect type text handling for international/unicode identifiers. - Pay close attention to
node-graph/libraries/core-types/src/types.rs- switch unmatched-text copying to UTF-8 character iteration to avoid Unicode corruption.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="node-graph/libraries/core-types/src/types.rs">
<violation number="1" location="node-graph/libraries/core-types/src/types.rs:383">
P2: Byte-wise `char` construction corrupts non-ASCII type names. Iterate by UTF-8 chars when copying unmatched text.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Keavon
force-pushed
the
user-facing-type-formatting
branch
from
May 14, 2026 06:07
d4b2856 to
3d30959
Compare
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some places that listed List now show Vector[], for example. "called with Context" is removed from node input type signatures. Places that used to write DVec2 now write Vec2 consistently, amongst other cases.