Skip to content

Implement dragging layers into the group/new/delete buttons in the Layers panel - #4153

Merged
Keavon merged 1 commit into
masterfrom
drag-layers-into-bottom-buttons
May 15, 2026
Merged

Keavon merged 1 commit into
masterfrom
drag-layers-into-bottom-buttons

Conversation

@Keavon

@Keavon Keavon commented May 15, 2026

Copy link
Copy Markdown
Member

No description provided.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a drag-and-drop system for the Layers panel, allowing users to drop layers onto action buttons such as Group, New Layer, and Trash. The changes include a new WidgetValueDragDrop message in the backend, an on_drag_drop callback for IconButton widgets, and frontend logic in Svelte to handle drag detection and event dispatching. Review feedback recommends refactoring the backend message handler to use existing callback logic for better maintainability and adopting more idiomatic Svelte event directives in the IconButton component.

Comment thread editor/src/messages/layout/layout_message_handler.rs
Comment thread frontend/src/components/widgets/buttons/IconButton.svelte
@Keavon
Keavon merged commit 06e2a04 into master May 15, 2026
10 checks passed
@Keavon
Keavon deleted the drag-layers-into-bottom-buttons branch May 15, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant