Skip to content

Hide node parameters connected to a NodeInput::Scope in the Properties panel - #4284

Merged
timon-schelling merged 1 commit into
masterfrom
fix-hide-scope-inputs
Jun 26, 2026
Merged

timon-schelling merged 1 commit into
masterfrom
fix-hide-scope-inputs

Conversation

@timon-schelling

@timon-schelling timon-schelling commented Jun 25, 2026

Copy link
Copy Markdown
Member
image image

@timon-schelling
timon-schelling requested a review from Keavon June 25, 2026 15:59

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a change to hide node inputs that are connected to a scope. The reviewer suggested a more direct and idiomatic approach to retrieve the input by index directly from the document node instead of constructing a temporary InputConnector.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Keavon Keavon changed the title Hide inputs connected to a scope in properties panel Hide node parameters connected to a NodeInput::Scope in the Properties panel Jun 26, 2026
@timon-schelling
timon-schelling added this pull request to the merge queue Jun 26, 2026
Merged via the queue into master with commit 21bf290 Jun 26, 2026
10 checks passed
@timon-schelling
timon-schelling deleted the fix-hide-scope-inputs branch June 26, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants