Skip to content

Revert #135 for fix crash from CT#874

Closed
Preta-Crowz wants to merge 1 commit into
GregTechCEu:masterfrom
Preta-Crowz:multifurnace-again
Closed

Revert #135 for fix crash from CT#874
Preta-Crowz wants to merge 1 commit into
GregTechCEu:masterfrom
Preta-Crowz:multifurnace-again

Conversation

@Preta-Crowz

Copy link
Copy Markdown
Contributor

What:
This PR reverts #135 for fix crash from CT

Outcome:
Revert #135

Additional info:
#135 caused compatibility issue to CT and it should be reverted.
Here's my crash log too.
crash-2022-04-08_20.08.32-client.txt

Possible compatibility issue:
Can cause another crash if someone used changed name to their code

@ALongStringOfNumbers

Copy link
Copy Markdown
Contributor

This PR is not going to be merged. The changes were made during a period of many breaking changes and a pre-beta state. However, we have taken measures to address the breaking changes made during this time period in our various addon mods.

Your crash is most likely coming about because you are using an outdated version of Multiblock Tweaker, and a Multiblock Tweaker version for GTCE, instead of the released version for GTCEu.

@Preta-Crowz

Copy link
Copy Markdown
Contributor Author

This PR is not going to be merged. The changes were made during a period of many breaking changes and a pre-beta state. However, we have taken measures to address the breaking changes made during this time period in our various addon mods.

Your crash is most likely coming about because you are using an outdated version of Multiblock Tweaker, and a Multiblock Tweaker version for GTCE, instead of the released version for GTCEu.

Why addon devs should fix it? It wasn't be happened if it doesn't changed and it might broke compatibility to other addons too.

@Preta-Crowz

Copy link
Copy Markdown
Contributor Author

But anyway, I agree there are many addons that already modified their code to GTCEu but it should not be happen anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants