Skip to content

[Enhancement] 原理图管理优化 - #6094

Merged
Glavo merged 129 commits into
HMCL-dev:mainfrom
ToobLac:litematica
Sep 17, 2026
Merged

Glavo merged 129 commits into
HMCL-dev:mainfrom
ToobLac:litematica

Conversation

@ToobLac

@ToobLac ToobLac commented May 16, 2026

Copy link
Copy Markdown
Contributor

Resolves #4052 Resolves #4518 Resolves #3957

#3597 应在本 PR 合并后并实现 NBT 修改功能后关闭

ToobLac added 5 commits August 6, 2026 12:04
# Conflicts:
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/MDListCell.java
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/SchematicsPage.java
#	HMCL/src/main/resources/assets/lang/I18N_uk.properties
# Conflicts:
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ModListPage.java
#	HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/SchematicsPage.java
#	HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/ModManager.java
#	HMCLCore/src/main/java/org/jackhuang/hmcl/game/DefaultGameRepository.java

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Static analysis found the following issues (max count 10):

Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/game/DefaultGameRepository.java Outdated
Comment thread HMCLCore/src/main/java/org/jackhuang/hmcl/game/DefaultGameRepository.java Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Static analysis found the following issues (max count 10):

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/util/SynchronizedLazy.java Outdated
@Glavo

Glavo commented Sep 10, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T12:35:10.636593Z e0bc9f1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2cd7d5db0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/SchematicsPage.java Outdated
@Glavo

Glavo commented Sep 11, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: e0bc9f1793

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Glavo Glavo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本审查建议由 GPT-5.6 Sol 生成


已将具体审查建议标注在对应代码行。

Comment thread HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/SchematicsPage.java Outdated
@Glavo
Glavo merged commit 13ad502 into HMCL-dev:main Sep 17, 2026
3 checks passed
@ToobLac
ToobLac deleted the litematica branch September 17, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

5 participants