Conversation
zkitefly
reviewed
Sep 13, 2026
Member
There was a problem hiding this comment.
Why do we need this file? Is there any connection between bash and java🤔
Member
There was a problem hiding this comment.
Why do we need this file? Is there any connection between bash and java🤔
看起来是 AI 生成的内容。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Linux/macOS fallback directly to HMCLauncher.sh after the existing lookup branches and before the Java-not-found warning, resolving SDKMAN's selected
candidates/java/current/bin/javafrom a nonempty SDKMAN_DIR or, when unset/empty, a nonempty HOME plus.sdkman. The reporter cannot start HMCL-3.6.18.297.sh on Ubuntu 25.04 after installing Java through SDKMAN, with both Dragonwell 21 and Liberica 25 reported affected.Reproduce the missing branch on Linux with JAVA_HOME and HMCL_JAVA_HOME absent and a controlled PATH containing only the bootstrap's required non-Java utilities: a temporary
.sdkman/candidates/java/currentsymlink targets an executable stub, and startup selects it successfully; establish that the existing script fails this scenario before the fix; Verify custom SDKMAN_DIR and SDKMAN_CANDIDATES_DIR roots, including spaces in the root and launcher filename; empty SDKMAN variables fall back appropriately, while an absent/empty HOME must never trigger a relative lookup in the working directory.Closes #4574