Skip to content

修复 #6038 中,实例列表中右键编辑时,不改实例名称就无法保存的问题 - #6866

Merged
Glavo merged 2 commits into
HMCL-dev:mainfrom
Hylfrd:fix/game-directory-edit
Sep 15, 2026
Merged

Glavo merged 2 commits into
HMCL-dev:mainfrom
Hylfrd:fix/game-directory-edit

Conversation

@Hylfrd

@Hylfrd Hylfrd commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

fix #6038 (comment)

并对自动起名加了null检测

@github-actions github-actions Bot added the 40+ label Sep 15, 2026
@Hylfrd Hylfrd changed the title 修复 #6000 中,实例列表中右键编辑时,不改实例名称就无法保存的问题 修复 #6038 中,实例列表中右键编辑时,不改实例名称就无法保存的问题 Sep 15, 2026
@Hylfrd

Hylfrd commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

我其实更倾向于 revert #6038,参考 #6646 (comment) ,我认为这个功能应当在 #3683 中一并处理掉,因为右键的动线在目前 HMCL 的UI设计中很诡异,整个HMCL就没有通过右键来完成某项功能的点,首先就很难找

@Glavo

Glavo commented Sep 15, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T12:14:52.233791Z 8fa9cd2 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 8fa9cd2fe7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Glavo
Glavo merged commit 090f0b9 into HMCL-dev:main Sep 15, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants