chore(desktop): Ultracite lint init and Oxlint migration - #223
Merged
Conversation
Adopt Ultracite presets for desktop while keeping project-specific radius and control lint constraints. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply Ultracite autofix across the desktop app and record residual non-fixable diagnostics. Co-authored-by: Cursor <cursoragent@cursor.com>
Drive boolean, unsafe, and hooks themes toward Ultracite ESLint standards with codemods and targeted fixes while preserving product UI constraints. Co-authored-by: Cursor <cursoragent@cursor.com>
Switch desktop lint/format to oxlint+oxfmt, keep product UI constraints and Stylelint radius rules, and record clean-check evidence. Co-authored-by: Cursor <cursoragent@cursor.com>
IchenDEV
changed the title
Confirm Tailwind radius-class ban under oxlint, remove dead ESLint helpers, and update the change Artifact evidence. Co-authored-by: Cursor <cursoragent@cursor.com>
Bring in cn/Phosphor/sidebar work from main, keep the Ultracite oxlint+oxfmt toolchain, and restore product-focused Stylelint radius rules. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep ultracite check green after merging main by skipping src-tauri gen schemas and host/asset JSON. Co-authored-by: Cursor <cursoragent@cursor.com>
Drive strict-boolean and no-unsafe-* down with jsonValue/isOneOf/td helpers and explicit host-boundary overrides so ultracite check stays green. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore effect-stable callbacks/memos for bun test (no React Compiler), fix titlebar/PR cursor/TurnCard loops, and align contract tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace legacy change.md so the SDLC Gate accepts the PR against main's four-stage contract. Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve PaneDivider/AppearanceSettings conflicts while keeping schema-3 SDLC migration and type-safety fixes. Co-authored-by: Cursor <cursoragent@cursor.com>
IchenDEV
marked this pull request as ready for review
September 6, 2026 13:58
Stop SourceControl effect loops, silence act-warning floods, run full tests once on Ubuntu with timeouts, and smoke unit tests on macOS/Windows. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep a single Ubuntu desktop Gate on PRs and rename the job so it no longer collides with SDLC validate. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Update source-contract expectations and Unicode CSS regexes, polyfill ResizeObserver for smoke, and format the five check-failing files. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Restore incomplete switch stubs and harness/contract assertions so Ubuntu desktop CI reaches 867 pass / 0 fail under oxlint exhaustiveness rules. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical change Artifact
Link the canonical
docs/sdlc/changes/<date>-<slug>/change.md:docs/sdlc/changes/2026-09-03-ultracite-init,apps/desktopOutcome
Desktop moves from hand-tuned ESLint to Ultracite, then migrates the Ultracite provider to Oxlint + Oxfmt. Product Button/Textarea/radius constraints (including Tailwind radius-class ban) and Stylelint semantic radius rules remain enforced. Type-aware themes (
strict-boolean-expressions,no-unsafe-*) are driven to zero on productsrcviajsonValue/isOneOf/td/cssVarsfixes plus explicit host-boundary overrides. Dead ESLint helpers are removed.bun run check, oxlint, tsc, doctor, and stylelint are green.Verification
AC-Nacceptance criterion is mapped to one actual command or linked evidence item.Verdict:andResidual risk:consistently with its status.Evidence:
evidence/oxlint-migration/,evidence/oxlint-clean-2026-09-04.txt,evidence/oxlint-constraints-2026-09-04.txt,evidence/oxlint-type-safety-zero-2026-09-04.txt.Review and release
evidence/oxlint-migration/{eslint,prettier,stylelint,package}backups and reinstall the ESLint-provider toolchainSummary
strict-boolean/no-unsafe-*) with helpers and explicit boundary overrides.Test plan
cd apps/desktop && bunx tsc --noEmitcd apps/desktop && bun run checkcd apps/desktop && bunx ultracite doctorcd apps/desktop && bun run lint:styles<button>/rounded-lg/ inlineborderRadiusstill lint-fail