Skip to content

Support code_challenge_methods_supported#55

Merged
rohe merged 1 commit into
IdentityPython:developfrom
ctriant:oauth-discovery
Apr 9, 2023
Merged

Support code_challenge_methods_supported#55
rohe merged 1 commit into
IdentityPython:developfrom
ctriant:oauth-discovery

Conversation

@ctriant

@ctriant ctriant commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

Add missing parameter code_challenge_methods_supported for PKCE

@ctriant ctriant requested review from c00kiemon5ter and rohe February 9, 2023 11:01
@ctriant ctriant force-pushed the oauth-discovery branch 2 times, most recently from e3e3298 to ec8a75e Compare February 9, 2023 16:00
@rohe

rohe commented Mar 30, 2023

Copy link
Copy Markdown
Contributor

@ctriant please resolve conflicts and fix failing checks.

@ctriant ctriant marked this pull request as draft April 3, 2023 08:13
@ctriant ctriant force-pushed the oauth-discovery branch 4 times, most recently from b890f54 to a987758 Compare April 4, 2023 11:41
@ctriant ctriant marked this pull request as ready for review April 4, 2023 11:41
Signed-off-by: Kostis Triantafyllakis <kostastriantaf@gmail.com>
@ctriant

ctriant commented Apr 4, 2023

Copy link
Copy Markdown
Contributor Author

@ctriant please resolve conflicts and fix failing checks.

@rohe please have a look at this. Should I add the code_challenge_methods_supported on the client claims in the new fedservice approach?

@rohe

rohe commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Not sure I get what you mean with client claims.

@ctriant

ctriant commented Apr 4, 2023

Copy link
Copy Markdown
Contributor Author

Not sure I get what you mean with client claims.

This dict

def test_supported(self):

@rohe

rohe commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

code_challenge_methods_supported is part of Server Metadata according to RFC8414 but, in our case, should only appear IFF the add_on pkce is defined. In the normal case with no add_on functionality it should not appear in the metadata.

test_08_transform.py doesn't deal with add_ons so code_challenge_methods_supported should not appear.

Just deal with the basic case right now. I'll tackle the add_ons.

@ctriant

ctriant commented Apr 5, 2023

Copy link
Copy Markdown
Contributor Author

So, do you suggest any further changes?

@rohe rohe merged commit bfbb452 into IdentityPython:develop Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants