main: implement saveScreenshot() writing bmp from SDL window buffer#10
Merged
Conversation
Collaborator
Author
|
@JF002 could you test if this PR creating bmp screenshots is working for you |
Contributor
|
It works for me! Thanks! 💯 I tried both BMP and PNG. I think PNG is better as the files are much smaller.
|
NeroBurner
added a commit
to NeroBurner/InfiniTime
that referenced
this pull request
Mar 8, 2022
InfiniSim PR InfiniTimeOrg/InfiniSim#10 adds support for screenshots in png format using a `libpng` submodule. This new submodule must be added to the lv_sim workflow as well.
When pressing `i` create a screenshot of the current InfiniTime screen by dumping it to a timestamped png or bmp file like `InfiniSim_2022-03-08_203421.png`. Add a new configure option `WITH_PNG` with default `ON`. When switched to `OFF` the screenshots will be created in `bmp` format. Fixes: #5
Collaborator
Author
|
updated with PNG support by adding a new configure option This also adds a new submodule |
NeroBurner
added a commit
to NeroBurner/InfiniTime
that referenced
this pull request
Mar 8, 2022
InfiniSim PR InfiniTimeOrg/InfiniSim#10 adds support for screenshots in png/bmp format using `libpng` submodule. This new submodule must be added to the lv_sim workflow as well.
NeroBurner
added a commit
to NeroBurner/InfiniTime
that referenced
this pull request
Mar 8, 2022
InfiniSim PR InfiniTimeOrg/InfiniSim#10 adds support for screenshots in png/bmp format using `libpng` submodule. This new submodule must be added to the lv_sim workflow as well.
JF002
pushed a commit
to InfiniTimeOrg/InfiniTime
that referenced
this pull request
Mar 8, 2022
InfiniSim PR InfiniTimeOrg/InfiniSim#10 adds support for screenshots in png/bmp format using `libpng` submodule. This new submodule must be added to the lv_sim workflow as well.
grad0s
pushed a commit
to aramcon-badge/InfiniTime
that referenced
this pull request
Jun 25, 2022
InfiniSim PR InfiniTimeOrg/InfiniSim#10 adds support for screenshots in png/bmp format using `libpng` submodule. This new submodule must be added to the lv_sim workflow as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pressing
icreate a screenshot of the current InfiniTime screenby dumping it to a timestamped bmp file.
Fixes: #5